phetsims / friction

"Friction" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/friction
GNU General Public License v3.0
4 stars 6 forks source link

(Description) Check screen reader behaviour #243

Closed terracoda closed 2 years ago

terracoda commented 2 years ago

Before RC we need to do sanity checks on screen reader experience for any major issues.

Note that in BASE issue https://github.com/phetsims/balloons-and-static-electricity/issues/508 we deferred some work in common code that would fix the mobile drag and grab interaction. Currently the visual keyboard grab hint shows up on touch devices.

We may need to continue to defer mobile accessibility for Friction as well if this common code issue cannot be addressed in a timely fashion.

UPDATE FROM MK: yes, mobile description a11y is deferred, see doc in https://github.com/phetsims/friction/issues/249

terracoda commented 2 years ago

VoiceOver issues on MacOs 11.4

  1. The reset hint has been permanently appended to the settled state, "Atoms jiggle a tiny bit, temperature cool. Reset sim to make more observations."

    • the reset hint has to be conditionally appended. It can't be heard if atoms are available to be evaporated.
  2. There is a huge amount of pile-ups. Hopefully, we have modernized the management of responses and it will be straightforward to address the pileups.

terracoda commented 2 years ago

VoiceOver issues on iOS 14.7.1 (iPhone 7)

  1. See visual keyboard hint on touch device (iphone) as noted in https://github.com/phetsims/balloons-and-static-electricity/issues/508

    • this needs to fixed in common code, or we leave iOS off for this release
  2. Hear ticking as sim loads (this must be built-in apple sonification)

  3. Screen reader behaviour is erratic. At first I could access state descriptions with swipes, now I can. At first, I was hearing pile-ups of responses and now I hear no responses. I only hear state descriptions.

terracoda commented 2 years ago

VoiceOver issues on iOS 14.6 (iPhone 8)

  1. keyboard grab hint visible (same as above)
  2. no ticking noise heard on iPhone 8 when sim was loading
  3. significant response pile ups happen. Hints like move down to rub harder and rub fast or slow seemed to interrupt more important warming-cooling responses and break away responses. But like above on subsequent testing I no longer hear responses. I can still access state descriptions.
terracoda commented 2 years ago

@Matthew-Moore240 please do a quick test with NVDA to see if there are obvious issues with pileups on that platform as well.

zepumph commented 2 years ago

From testing on NVDA:

zepumph commented 2 years ago

On hold until https://github.com/phetsims/friction/issues/253 can be fixed. That issue is too large to get good results from other testing.

terracoda commented 2 years ago

Also noting this version of Friction will not be published with iOS Interactive Description, so we will not be addressing https://github.com/phetsims/balloons-and-static-electricity/issues/508

zepumph commented 2 years ago

Agreed! See https://github.com/phetsims/friction/issues/249 for notes on the discussion we had.

zepumph commented 2 years ago

Ok, https://github.com/phetsims/friction/issues/253 is done. Ready for a final review with PDOM again.

zepumph commented 2 years ago

Review on hold until https://github.com/phetsims/friction/issues/258, I'll give a dev version when ready.

zepumph commented 2 years ago

Alright, ready to review, please test with https://phet-dev.colorado.edu/html/friction/1.6.0-dev.18/phet/friction_all_phet.html

terracoda commented 2 years ago

I checked VO on MacOS and VO on iOS. Both sound pretty good. VO on iOS will need a bit more work, but this version is being published with iOS A11y.

For iOS, just noting along with the visual keyboard hint, I had some pile ups of move down to rub harder.

Matthew-Moore240 commented 2 years ago

This all sounded really good to me. The only thing was that I had to do the long swipes across the book to get the now hotter and warming alerts but I had no pile-up or anything like that.

zepumph commented 2 years ago

Ready to close. Thanks!