phetsims / friction

"Friction" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/friction
GNU General Public License v3.0
4 stars 6 forks source link

(Interactive Description) I hear "Move down to rub harder" before I try to rub #257

Closed terracoda closed 2 years ago

terracoda commented 2 years ago

This hint has to be linked to unproductive rubbing. It is now working well in Voicing, but not yet working well in on grab when using VoiceOver on MacOs and keyboard.

I do get the hint BEFORE and after non-productive rubbing.

This issue might resolve itself, but the design goal is to only get this hint when unproductive rubbing is occurring and not immediately as part of the grab when the books are apart.

zepumph commented 2 years ago

I do get the hint BEFORE

This is true, but I think incomplete.

The way it was:

The "move down to rub harder" alert for pdom alerts was added on if the books weren't touching AND there had been successful rubbing. I was able to get this alert to fire when I made successful rubbing, then made the books not touch, released the book, and then grabbed it again.

After my commit

I have completely removed this hint from the grabbed alerts in the PDOM. Instead, you will only get them based on logic that looks at how you are rubbing, and if you rub too much without touching the books. @terracoda please review.

terracoda commented 2 years ago

Sounds good. Thanks! We changed the logic for Voicing and Description, that move down to rub harder only fires early in the interaction before too many atoms have broken away.

I am a little concerned that this might be confusing for some learners, especially learners who cannot see the screen, but I am willing to leave it as is. The hint works well for initial rubbing and it doesn't fire every time there is space created between the books. Hopefully, the early explicit hint implicitly scaffolds the rest of the rubbing.

Closing.