search

phetsims / friction

"Friction" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/friction
GNU General Public License v3.0
4 stars 6 forks source link

(Voicing) Can we optimize responses with alt input keyboard? #258

Closed terracoda closed 2 years ago

terracoda commented 2 years ago

In #242 and #253 and other issues we improved the experience greatly for both mouse and keyboard.

I feel a second look at optimizing the alt input keyboard experience would be good, if there is time.

In #253 I mentioned 2 specific issues.

  1. often an extra super fast, super hot response after rubbing stops, and
  2. rare occurrences (possibly no occurrences) of "jiggling more, warmer" as temperatures increase.
zepumph commented 2 years ago

@terracoda was using smaller key presses than I was. I'll take a look.

zepumph commented 2 years ago

I found the issue, each time you let go of all keys, it is considered an endDrag, and we were clearing the warming alerts that were in the queue on end drag. For longer key presses, it was long enough to "escape" the queue and be alerted, but for shorter alerts they were cleared before spoken.

Ready to review the other issues. You can test this in master or in https://phet-dev.colorado.edu/html/friction/1.6.0-dev.18/phet/friction_all_phet.html.