Closed Nancy-Salpepi closed 2 years ago
There are quite a few spots where we are using html in our strings for a11y, since they were going into the PDOM. We need to split those out most likely, or come up with a way to remove the formatting tags.
Looks like @jessegreenberg will be handling this on master and patching old versions over in https://github.com/phetsims/scenery/issues/1309. @jessegreenberg I just thought you should be aware of this sim-issue as well.
I see, thanks. The plan in https://github.com/phetsims/scenery/issues/1309 would not cover cases like this for Voicing. The fix there will simply be to replace <br>
with <br/>
, but the <br/>
would also be ready by SpeechSynthesis. I think we will need another way to remove all formatting tags before speaking.
I started https://github.com/phetsims/scenery/issues/1314 for this.
Right, thanks! I'll take the lead over in https://github.com/phetsims/scenery/issues/1314.
Just waiting on review over in https://github.com/phetsims/scenery/issues/1314.
Alright, review is complete. @Nancy-Salpepi can you confirm this is fixed on master please?
Feel free to close.
This is fixed :) Closing.
Test device MacBook Air (m1 chip)
Operating System iOS 11.6
Browser safari 15
Problem description https://github.com/phetsims/qa/issues/717
The line break element is read with Voicing in the 'Grab or Release Book' section of the Keyboard Shortcuts Dialog.
Steps to reproduce
Visuals
https://user-images.githubusercontent.com/87318828/137138687-8516ef1f-2d93-4cd1-b5ad-c9e659e50087.mov