search

phetsims / friction

"Friction" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/friction
GNU General Public License v3.0
4 stars 6 forks source link

Should Voicing continue with sim descriptions after preferences menu is opened? #263

Closed Nancy-Salpepi closed 2 years ago

Nancy-Salpepi commented 2 years ago

Test device MacBook Air (m1 chip)

Operating System iOS 11.6

Browser Safari 15

Problem description https://github.com/phetsims/qa/issues/717

After the Preferences Menu is opened, Voicing continues to report changes happening in sim.

Steps to reproduce

  1. Turn on voicing and check all checkboxes
  2. Quickly rub chemistry book back and forth on physics book
  3. While descriptions are happening, click on Preferences Menu

Visuals

https://user-images.githubusercontent.com/87318828/137155236-5aff6052-7811-4fb3-93ce-b0e3460ea5b3.mov

Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Friction‬ URL: https://phet-dev.colorado.edu/html/friction/1.6.0-dev.19/phet/friction_all_phet.html Version: 1.6.0-dev.19 2021-10-08 22:59:15 UTC Features missing: touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.0 Safari/605.1.15 Language: en-US Window: 1440x675 Pixel Ratio: 2/1 WebGL: WebGL 1.0 GLSL: WebGL GLSL ES 1.0 (1.0) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 31 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
terracoda commented 2 years ago

We'll want to address this for Friction, see phetsims/joist#752

emily-phet commented 2 years ago

The issue of prioritizing what utterances are read when, and what gets interrupted, has been discussed significantly over the past two weeks in the Voicing wednesday meetings with @terracoda, @jessegreenberg and others. My impression is that addressing this is a larger issue that will be done soon-ish, but should not block sims currently in the publication pipeline (i.e., those going through QA). @jessegreenberg and @zepumph can you confirm this is your impression as well?

If so, perhaps this should be marked as "deferred", or closed referencing the main joist issue?

zepumph commented 2 years ago

I think that is correct. It seems like this issue goes hand in hand with https://github.com/phetsims/joist/issues/752

terracoda commented 2 years ago

I think the work in https://github.com/phetsims/joist/issues/752 is working well.

At this point (June 29, 2022) there is a nice balance between what is happening in the background and any interactions the user is taking in an opened preferences dialog.

I think this issue can be closed.

zepumph commented 2 years ago

Excellent! I think so too