Closed Nancy-Salpepi closed 2 years ago
These buttons switch back to the "play" icon from the voicingManager.endSpeakingEmitter so my first guess is that that emitter is not being emitted for some reason.
@jessegreenberg is planning to do some work to the utterance queue re priorities for when things are read out, when things are interrupted, etc. This seems related, or at least, likely in that ballpark area of Voicing work.
I don't think this should block further progress toward publication for Friction.
@jessegreenberg - I'm not sure if I should mark this as deferred, or if it should be listed in a different repo to be considered for some of the general Voicing work you'd like to do.
Another thought - @Nancy-Salpepi can you check if this same issue happens in other sims with voicing on iPad (e.g., JT and GFLB)?
I just want to check if this is Friction specific, or general.
@emily-phet I was easily able to reproduce this in JT (published) and GFLB (Master).
We want to verify that the end
event is not triggering. If that is the case it will likely be a browser bug and we will need to look into a workaround. I started https://github.com/phetsims/scenery/issues/1315 to investigate.
This seems like a relatively minor usability issue to me. If @jessegreenberg finds this to be relatively straightforward to fix, or relatively straightforward to identify as a browser bug, then let's fix it in the case of it not being a browser bug. If it's a browser issue or a fix that's likely to delay publication, then I don't think this should be blocking for publication of Friction.
Today during voicing meeting we decided this won't block friction, @jessegreenberg will investigate for https://github.com/phetsims/scenery/issues/1315.
I suspect this has been fixed with https://github.com/phetsims/utterance-queue/issues/66. I tried to get the original issue to happen on my iPad Air 2 and could not. @Nancy-Salpepi if you have a moment can you please test?
@jessegreenberg sometimes when both buttons are pressed at the same time, I hear the 'Reset All' sound and voicing either says "reset all" and then reads the Quick Info statements or reads the statements and then says "reset all".
I was not able to reproduce the original issue.
Videos:
None of the above videos seemed like a bug to me. I think it is reasonable that you could hear one or both of the responses depending on how things end up in the queue. I don't think it is worth looking into this edge case any more. I'm going to close. Please reopen if you feel differently.
Test device iPad Air 2 (name: Leibniz)
Operating System 15.0.1
Browser safari
Problem description https://github.com/phetsims/qa/issues/717
On the iPad: When the reset button is pressed at the same time as one of the 'Read Me' buttons, the sim will reset. However, the 'Read Me' button will look like it is in play mode--a STOP symbol is present. If reset is pressed again, the button will not change back to a PLAY symbol.
Steps to reproduce
Visuals
https://user-images.githubusercontent.com/87318828/137532925-b905fe35-a665-4394-9c98-414cd9e83475.mov