phetsims / friction

"Friction" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/friction
GNU General Public License v3.0
4 stars 6 forks source link

Things should be read that aren't #269

Closed KatieWoe closed 2 years ago

KatieWoe commented 2 years ago

Test device Dell Operating System Win 11 Browser Chrome Problem description For https://github.com/phetsims/qa/issues/717. The about dialog no longer reads out items when clicked on. They were read out in the published version of JT. In addition, the Physics and Chemistry labels on the testbooks aren't read out when clicked on.

Troubleshooting information:

!!!!! DO NOT EDIT !!!!! Name: ‪Friction‬ URL: https://phet-dev.colorado.edu/html/friction/1.6.0-dev.19/phet/friction_all_phet.html Version: 1.6.0-dev.19 2021-10-08 22:59:15 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/95.0.4638.54 Safari/537.36 Language: en-US Window: 1280x649 Pixel Ratio: 1.5/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 4096 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 32767x32767 OES_texture_float: true Dependencies JSON: {}
stemilymill commented 2 years ago

The check for updates dialog also does not read "This simulation is up to date" like it should.

https://user-images.githubusercontent.com/85511101/139120766-11ddcc28-2b72-47dc-830d-ca6dbac821ba.mp4

zepumph commented 2 years ago

I see that all items in the aboutDialog are readingblocks in JT (https://phet.colorado.edu/sims/html/john-travoltage/latest/john-travoltage_en.html), but not in Friction on master. @jessegreenberg can you recommend how to proceed? Is it a bug, or is there something I'm not opting into.

zepumph commented 2 years ago

I can confirm that JT on master also doesn't have these reading blocks. Over to @jessegreenberg for some assistance.

jessegreenberg commented 2 years ago

Sorry about this. In order to get john-travoltage out I added a quick sim-specific solution to get certain text readable without impacting master. We should have an easier time instrumenting these Dialogs now. I created joist issues to do this, https://github.com/phetsims/joist/issues/763.

jessegreenberg commented 2 years ago

https://github.com/phetsims/joist/issues/763 was done and is ready for review, this should no longer be an issue for Friction.

zepumph commented 2 years ago

Thanks! Removing blocking label, as things are working well in friction.

Nancy-Salpepi commented 2 years ago

Looks good on master.