Closed terracoda closed 2 years ago
@terracoda, I wonder, were you testing on the published version? In master this is what I see when I grab the macro book:
We did quite a bit of work in the common code of GrabDragInteraction when doing it for the Ruler in ISLC, so it is quite possible that much of what you were talking about is already in master.
When I test with NVDA I hear: "Chemistry book, movable" the "Grabbed, lightly on physics book"
I created https://phet-dev.colorado.edu/html/friction/1.6.0-dev.23/phet/ so you can test more easily.
I don't hear duplication any more in the link you gave me. https://phet-dev.colorado.edu/html/friction/1.6.0-dev.23/phet/
Friction is set to be published this quarter, so hopefully we will have this fixed in production soon!
I see the following code in the inspector, and I think there is too much repetition of "Movable Chemistry book" in this interaction.
When using VoiceOver, I hear the following on grab:
Ideally, I should only hear:
I think to fix this issue we need to do the following:
aria-label
attributes and the content of the draggablediv
elements to:aria-label="Chemistry book"
andaria-label="Zoomed-in Chemistry book"
aria-roledescription="movable"
in both cases.I do not hear this level of repetition in the case of the grabbed "Ruler" in Gravity Force Lab nor in the case of the grabbed "Bar Magnet" in Faraday's Law. In Balloons and Static Electricity, it is hard to tell because of timing differences, but I think the balloons are coded as above.
I think this is a common code interaction, so it's possible Friction has not been updated to the final common code? Please check on that. (edit) Please check in case there is some reason why we have done this interaction differently in Friction.