phetsims / friction

"Friction" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/friction
GNU General Public License v3.0
4 stars 6 forks source link

Assertion errors in ?fuzz test with debug version #315

Closed Nancy-Salpepi closed 1 year ago

Nancy-Salpepi commented 1 year ago

For https://github.com/phetsims/qa/issues/868, with macOS 13.0.1 and safari 16.1 I saw a few assertion errors when running a ?fuzz test with https://phet-dev.colorado.edu/html/friction/1.6.0-dev.28/phet/friction_all_phet_debug.html

Screenshot 2022-12-23 at 1 19 14 PM

Here is the detailed view:

Screenshot 2022-12-23 at 1 18 13 PM Screenshot 2022-12-23 at 1 18 34 PM Screenshot 2022-12-23 at 1 18 48 PM
KatieWoe commented 1 year ago

Found the steps to replicate:

  1. Go to the Hatian locale
  2. Try to open the Keyboard Nav dialog

wack

KatieWoe commented 1 year ago

This is what that translation looks like in the published version: onpub

The "undefined" in the problem string leads me to think that is the place to look.

KatieWoe commented 1 year ago

I didn't see this in any other locale

zepumph commented 1 year ago

@marlitas and I looked into this and found that without assertions you can get this look:

image

It looks like we have trouble related to https://github.com/phetsims/babel/issues/18. I'll ping over there to see if we can get this fixed before publication. Noting that {{chose}} is in the "Results" in https://github.com/phetsims/babel/issues/18#issuecomment-1355853503.

zepumph commented 1 year ago

@oliver-phet was kicking off some builds last night and I believe it was in regards to https://github.com/phetsims/babel/issues/18. I see notes about that over in https://github.com/phetsims/rosetta/issues/329#issuecomment-1371558337. scenery-phet strings weren't done because common code strings pose extra challenges, I'll keep this issue open.

zepumph commented 1 year ago

Looks like all has been resolved here over in https://github.com/phetsims/babel/issues/18. Closing