Closed Nancy-Salpepi closed 1 year ago
One way to fix this is to increase the priority of the releasedUtterance
in GrabDragInteraction. The name response that is spoken on focus is just cancelling the released
Utterance.
With VoiceOver, when I tab to the Reset All button, I first hear "Reset All button" and then I hear "Released," which I think is a bit confusing.
It would be most efficient if @jessegreenberg and or I worked on this one for the timing tweaks.
I didn't get to this today, @jessegreenberg I'll try for tomorrow
@zepumph and I increased the priority and confirmed the behavior is good. The increased priority also made it so the releaseUtterance interrupts text like Grabbed. Lightly on Physics book.
and also the object responses like Atoms jiggle a tiny bit, temperature cool.
but we agreed that is for the best, since the user has moved to something else. Therefore, we removed the cancelOther: false (which was added in https://github.com/phetsims/friction/issues/212#issuecomment-901501404)
This issue is ready to cherry-pick 2 commits.
cherry-pick
ed the two commits, and tested in RC SHAs. Ready to verify.
@jessegreenberg You added ready-for-review, but no assignee to review. So assigning to you.
Sounds good in rc.3. Closing.
Test device MacBook Air (m1 chip)
Operating System 13.1
Browser safari and chrome
Problem description For https://github.com/phetsims/qa/issues/886, with Voicing enabled I don't hear "released" if I tab to another object, such as the Reset All button. In older dev versions such as 1.6.0-dev.23, I do hear "released" when I press Tab. I still hear "released" when I let go of the book with my mouse.
Steps to reproduce
Visuals
https://user-images.githubusercontent.com/87318828/214592186-56db03ad-e824-45ee-8138-690bb906da8f.mov