phetsims / friction

"Friction" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/friction
GNU General Public License v3.0
4 stars 6 forks source link

Quick info alerts interrupted with Chrome 109 #327

Closed zepumph closed 1 year ago

zepumph commented 1 year ago

For cherry picking https://github.com/phetsims/joist/issues/898 into the rc branch

jessegreenberg commented 1 year ago

Here is the commit to cherry-pick: https://github.com/phetsims/utterance-queue/commit/2f64e9580771087750bdc3f1c5ac778abb089f1f

jessegreenberg commented 1 year ago

Before cherry-picking, I tried to reproduce the problem in current friction-1.6 SHAs and could not. I tried to reproduce it in rc.1 and could not. But I DO see it in dev.38.

I see https://github.com/phetsims/utterance-queue/commit/2f64e9580771087750bdc3f1c5ac778abb089f1f already in friction-1.6 SHAs. I don't know how it could have been in friciton-1.6, but believe it is already fixed.

pixelzoom commented 1 year ago

@jessegreenberg Who added ready-for-review, but no assignee to review. So assigning to you.

jessegreenberg commented 1 year ago

This is in the QA process and is being reviewed in in the next RC.

Nancy-Salpepi commented 1 year ago

This looks good in rc.3. Closing.