search

phetsims / friction

"Friction" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/friction
GNU General Public License v3.0
4 stars 6 forks source link

Muting sound through preferences is not stateful #338

Closed KatieWoe closed 1 year ago

KatieWoe commented 1 year ago

Device Dell OS Win 11 Browser Chrome Problem Description From https://github.com/phetsims/qa/issues/886

Some preference selections are saved into the simulation state, and persist in the save and launch process of the Standard PhET-iO Wrapper. These include audioEnabledProperty, colorProfileProperty, and all settings on the Simulation tab.

However, if you use the preferences menu to disable sounds, this is not carried over in state. The audio features toggle is and so is the nav bar button.

Visuals

soundsoff
arouinfar commented 1 year ago

@KatieWoe the only stateful property related to audio is general.view.audioManager.audioEnabledProperty which is hooked up to the "Audio Features" toggle and the Audio Toggle button in the navbar. The Sound toggle in the Preferences dialog is powered by a different property, general.view.soundManager.enabledProperty which is not intended to be stateful. Closing.