search

phetsims / function-builder

"Function Builder" is an educational simulation in HTML5, by PhET Interactive Simulations at the University of Colorado Boulder.
GNU General Public License v3.0
4 stars 4 forks source link

Function Builder - publish 1.2 with LoL support #139

Closed pixelzoom closed 2 years ago

pixelzoom commented 2 years ago

@kathy-phet said that it would be beneficial for Legends of Learning to republish Function Builder from master. Function Builder is not a PhET-iO sim, so this will be core features. This also includes Function Builder: Basics.

The plan is:

There are no outstanding issues in the function-builder and function-builder-basics repos, and no general "blocked" issues relevant to these sims. So this work can proceed immediately.

@amanda-phet FYI.

pixelzoom commented 2 years ago

The published version is 1.0.x, so I was expecting to be publishing 1.1.x. But when I went to publish the dev version of function-builder, it was 1.2.x. Then I discovered a 1.1-phetio branch (and many published versions) that I wasn't aware of, or didn't recall. Since function-builder has no PhET-iO instrumentation, this is confusing and concerning, and will be investigated in https://github.com/phetsims/function-builder/issues/140.

In the meantime, I'll advance both function-builder and function-builder-basics to 1.2 (so that their minor version numbers are in sync), and proceed with dev deploy.

pixelzoom commented 2 years ago

1/22/22 dev versions published for testing:

pixelzoom commented 2 years ago

Higher-priority issues were added to the QA queue, so https://github.com/phetsims/qa/issues/766 and https://github.com/phetsims/qa/issues/767 did not move forward, and will require new dev versions. QA will contact me when they are ready to proceed.

pixelzoom commented 2 years ago

@KatieWoe said in Slack:

There should be room for the function builder devs now

I published new dev versions:

pixelzoom commented 2 years ago

Slack to @amanda-phet and @kathy-phet:

Chris Malley 4:00 PM QA has completed dev testing for Function Builder & Function Builder: Basics. There are 3 issues, none sim-specific: https://github.com/phetsims/function-builder/issues/142 https://github.com/phetsims/function-builder/issues/143 https://github.com/phetsims/function-builder/issues/144 Kathy decided to wait for a fix for https://github.com/phetsims/function-builder/issues/142. And there have been a very large number of common-code changes (TypeScript conversions) since I published these dev versions. So I’m concerned that creating a release branch (even today, much less next week) is likely to pick up common-code regressions that will need to be patched during RC testing. How would you like to proceed?

Kathy Perkins 4:37 PM Let's see when phetsims/function-builder#142 is fixed, and then we can do a dev test. Not bad idea to test for regressions with another dev.

pixelzoom commented 2 years ago

Status as of 2/16/2022 @ 4:17PM MST:

pixelzoom commented 2 years ago

2/17/22 design meeting:

TypeScript conversion is the priority for Q1 2022, and it's therefore difficult to minimize common-code changes between the time of publishing dev version for testing, and creating release branches after testing has completed. So we decided to pause further work on this issue until the beginning of Q2. Around 4/1, PhET is planning to re-deploy a batch of PhET-iO sims, and there will be a window around that time during which common-code changes will be paused. At that time, we'll begin a new (full) dev test for this sim.

pixelzoom commented 2 years ago

On hold until PHET-iO batch release https://github.com/orgs/phetsims/projects/44 happens.

pixelzoom commented 2 years ago

At 5/12/22 dev meeting, @kathy-phet asked me to decouple this from the PhET-iO batch release, which is delayed.

On 5/19/22, @KatieWoe said that QA has capacity to do dev testing. I published these dev tests:

EDIT: dev tests completed 5/24/2022

pixelzoom commented 2 years ago

Slack#design-sims 5/26/2022:

Chris Malley 8:53 AM Since I’m out today, here’s a quick “check in” update on Function Builder.

Dev testing was completed for 1.2 release. Most of the issues were common-code issues, and all but 1 have been addressed. https://github.com/phetsims/scenery/issues/1424 is a showstopper: the Screenshot feature is crashing on iPad Air 2. This issue will require @jonathanolson to investigate, and it’s unclear when he’ll get a test device, or how this will be prioritized. This problem is almost certainly not specific to FB, so a batch MR may be required.

So… I’m not sure about how to proceed with FB. It’s been 1 week since I created the dev tests, and there have been many changes to master. If we further delay creating the 1.2 branch, then we’ll need to repeat dev testing after phetsims/scenery#1424 is fixed. If I create 1.2 now, we can continue with RC testing, but will need to apply a patch for phetsims/scenery#1424 (or possibly publish with the crash, and fix via a batch MR).

@kathy-phet @amanda-phet thoughts?

Kathy Perkins 11:10 AM Please continue and create the rc. Thanks

RC tests published on 5/26/2022:

EDIT: RC tests completed 6/7/2022.

pixelzoom commented 2 years ago

We decided to do another RC spot-check, to patch in #150 (Screenshot crash).

RC tests published 6/10/2022:

EDIT: RC tests completed 6/8/2022.

pixelzoom commented 2 years ago

In order to update QA credits for #141, I patched function-builder 1.2 and function-builder-basics 1.2, then published 1.2.0-rc.3 for both sims. As with last-minute credits updates that have been done in the past, these RCs were not QA tested. I spot-checked the About dialog, to make sure the credits looked correct.

pixelzoom commented 2 years ago

Function Builder 1.2.0 and Function Builder: Basics 1.2.0 were published to the PhET website. Closing.