search

phetsims / function-builder

"Function Builder" is an educational simulation in HTML5, by PhET Interactive Simulations at the University of Colorado Boulder.
GNU General Public License v3.0
4 stars 4 forks source link

Slot outline seen when trying to move a card backwards with Firefox #149

Closed Nancy-Salpepi closed 2 years ago

Nancy-Salpepi commented 2 years ago

Test device Dell

Operating System Win10

Browser Firefox

Problem description For https://github.com/phetsims/qa/issues/804 and https://github.com/phetsims/qa/issues/805, the dashed outline of the slot is visible when trying to drag an output card backward through an invertible function. This is very minor and doesn't affect the usability of the sim, but still wanted to mention.

I also see this in the published sims and when using mac + FF, although the issue isn't as obvious on the mac. Phettest isn't working properly at the momen,t so didn't test there. Not seeing this with safari or chrome.

Steps to reproduce Here is an example:

  1. In the Patterns screen, add the camera function to the builder.
  2. Drag any card through the function.
  3. Try to drag the card backward through the function.

Visuals dashed outline

Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Function Builder‬ URL: https://phet.colorado.edu/sims/html/function-builder/latest/function-builder_en.html Version: 1.0.25 2022-05-06 11:04:47 UTC Features missing: touch User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:100.0) Gecko/20100101 Firefox/100.0 Language: en-US Window: 1448x798 Pixel Ratio: 1/1 WebGL: WebGL 1.0 GLSL: WebGL GLSL ES 1.0 Vendor: Mozilla (ANGLE (Intel, Intel(R) HD Graphics 400 Direct3D11 vs_5_0 ps_5_0)) Vertex: attribs: 16 varying: 30 uniform: 4096 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 32767x32767 OES_texture_float: true Dependencies JSON: {"assert":{"sha":"7d27130a","branch":"HEAD"},"axon":{"sha":"9a0e2f3a","branch":"HEAD"},"babel":{"sha":"4cf48251","branch":"master"},"brand":{"sha":"827202bf","branch":"HEAD"},"chipper":{"sha":"58096b65","branch":"HEAD"},"dot":{"sha":"3628c3ae","branch":"HEAD"},"function-builder":{"sha":"921a1bcc","branch":"HEAD"},"joist":{"sha":"d6559dc0","branch":"HEAD"},"kite":{"sha":"88f0c3a0","branch":"HEAD"},"phet-core":{"sha":"718ca784","branch":"HEAD"},"phetcommon":{"sha":"84d5c397","branch":"HEAD"},"phetmarks":{"sha":"3fdfece0","branch":"HEAD"},"scenery":{"sha":"9f1bbb37","branch":"HEAD"},"scenery-phet":{"sha":"512f6f77","branch":"HEAD"},"sherpa":{"sha":"03590a07","branch":"HEAD"},"sun":{"sha":"cccaf534","branch":"HEAD"},"tandem":{"sha":"a8ac284b","branch":"HEAD"},"twixt":{"sha":"53b31872","branch":"HEAD"}}
pixelzoom commented 2 years ago

Reproduced on macOS 12.3.1 + FF 100.0.2. This is probably yet-another scenery bounds issue, affecting what parts of the screen are redrawn. I recommend that we do nothing, and close as "won't fix". @amanda-phet if you agree, please close.

amanda-phet commented 2 years ago

Thanks for being so thorough @Nancy-Salpepi ! I agree with @pixelzoom that this shouldn't be addressed if the root is a scenery bounds issue. It doesn't seem worthwhile at this time.