search

phetsims / function-builder

"Function Builder" is an educational simulation in HTML5, by PhET Interactive Simulations at the University of Colorado Boulder.
GNU General Public License v3.0
4 stars 4 forks source link

Sim can crash when taking screenshots #150

Closed pixelzoom closed 2 years ago

pixelzoom commented 2 years ago

For https://github.com/phetsims/qa/issues/804 and https://github.com/phetsims/qa/issues/805.

This is a general issue, see https://github.com/phetsims/scenery/issues/1424. Blocking and on-hold until that issue is addressed.

pixelzoom commented 2 years ago

In the above commits, I patched scenery branches function-builder-1.2 and function-builder-basics-1.2.

shas that were cherry-picked:

https://github.com/phetsims/scenery/commit/e761ef4da06cc8c4e1a5c0578d68d0db5b34a4ad https://github.com/phetsims/scenery/commit/ace23fc4566773387bb33efa9960b4248b702f5f

pixelzoom commented 2 years ago

To verify in 1.2.0-rc.2 (for https://github.com/phetsims/qa/issues/813 and https://github.com/phetsims/qa/issues/814):

History for the general issues is in https://github.com/phetsims/scenery/issues/1424.

If this verifies OK, please close this issue.

KatieWoe commented 2 years ago

I was unable to reproduce this in RC 2. Closing