revisit performance on Win10 + Chrome

phetsims / gas-properties

"Gas Properties" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

6 stars 6 forks source link

revisit performance on Win10 + Chrome #146

Closed pixelzoom closed 5 years ago

pixelzoom commented 5 years ago

In https://github.com/phetsims/gas-properties/issues/144#issuecomment-512569554, @KatieWoe reported performance on a range of platforms (abbreviated below). Frame rates are for the built version running with ?profiler.

Some of these should be examined before RC testing, to see whether they are OK or require attention. The most curious one is Win10 + Chrome.

OS & version	Browser & version	1.0.0-dev.40 fps
Win 10	Chrome	~35
Win 10	Firefox	~54
Win 10	Edge	60
Win 10	IE	32
Mac 10.14	Chrome	60
Mac 10.14	Safari	~56
Chrome OS	Chrome OS	60
iOS 12	Safari	60
Mac 10.10	Safari	60
iOS 9	Safari	7

chrisklus commented 5 years ago

I'm seeing ~60fps in both versions on macOS + Chrome (MacBookPro15,1), so it's difficult for me to tell whether these optimizations had any impact.

For quick performance iteration of problems only affected by slower devices, I often throttle Chrome's CPU x4 under the performance tab of dev tools.

KatieWoe commented 5 years ago

I'm actually getting 55-60 for both now as well. Tried another situation too, just in case. I wonder if another Chrome update helped.

pixelzoom commented 5 years ago

Thanks @chrisklus. With 4x CPU throttling, I'm still seeing 60fps with both versions on macOS + Chrome (MacBookPro15,1).

Thanks @KatieWoe. Unfortunately we have no Chrome version numbers for any of our previously reported results. I don't know what else could be responsible for the 1.0.0 improvement that you're reporting - a Chrome update is a good guess.

So... Since the Win10+Chrome performance is now on par with other platforms, I'm going to refrain from making the remaining optimizations that were proposed in https://github.com/phetsims/gas-properties/issues/146#issuecomment-524941060, since they are expected to yield negligible improvement.

pixelzoom commented 5 years ago

To verify in RC testing:

Run on Win10+Chrome with ?profiler and verify that the performance is acceptable. The worst case performance is the the Energy screen, both histograms expanded, all checkboxes checked for the histograms.
Spot check on a fe platforms to verify that the histograms are rendered correctly.
Spot check on a few platforms to verify that particles inside and outside the container are correctly rendered.

KatieWoe commented 5 years ago

All looks good to me rc.1