Collision Counter should be off by default

phetsims / gas-properties

"Gas Properties" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

6 stars 6 forks source link

Closed arouinfar closed 3 months ago

arouinfar commented 4 months ago

Discovered during review for #30

@Nancy-Salpepi noticed that the Collision Counter is on by default, which differs from the published version the simulation.

Given that the Collision Counter isn't central to the primary learning goal (PV=NkT), let's keep it off by default.

pixelzoom commented 3 months ago

This bug was introduced by @zepumph in https://github.com/phetsims/gas-properties/commit/1b7cbcbfb15705d301519e6ec65048068d75832a, way back on 1/9/23, apparently for work that he was doing in chipper. Fixed in the above commits.

@Nancy-Salpepi please verify in main, close if OK.

Nancy-Salpepi commented 3 months ago

Looks good in main. Closing.