phetsims / gas-properties

"Gas Properties" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 6 forks source link

Link `model.histogramsModel` under each `histogramNode` #253

Closed arouinfar closed 3 weeks ago

arouinfar commented 1 month ago

For #30

It would be helpful to link the histogram data, found under model.histogramsModel to the histogramNode view element. image

My initial instinct was to add a link to the specific histogram, but it seems like the histogramsModel.kineticEnergy and histogramsModel.speed are just organizational and not instrumented things. (Nothing shows up in the Element Panel when I select them in the tree.) image

If I'm mistaken and we can link to histogramsModel.kineticEnergy and histogramsModel.speed, let's do that. Otherwise, linking to histogramsModel is perfectly fine.

@pixelzoom please

pixelzoom commented 3 weeks ago

If I'm mistaken and we can link to histogramsModel.kineticEnergy and histogramsModel.speed, let's do that. Otherwise, linking to histogramsModel is perfectly fine.

Linking to histogramsModel.kineticEnergy and histogramsModel.speed would require some relatively major code changes. So I linked to histogramsModel, and added phetioFeatured: true where requested.

@arouinfar please review, close if OK.

arouinfar commented 3 weeks ago

Thanks @pixelzoom! Looks good in main, closing.