search

phetsims / gas-properties

"Gas Properties" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 6 forks source link

Create `checkboxGroup` for species checkboxes in histograms #254

Closed arouinfar closed 5 months ago

arouinfar commented 5 months ago

For #30

The Speed and Kinetic Energy histograms have checkboxes to display the data for a single particle type. image

I can see a client wanting to hide both checkboxes, but not just one. @Nancy-Salpepi and I think it would be nice to create a checkboxGroup that contains both heavyParticlesCheckbox and lightParticlesCheckbox. We could then feature checkboxGroup.visibleProperty and uninstrument the individual child checkbox.visibleProperty.

I recognize that request is treading into scope-creep territory, so feel free to veto @pixelzoom.

pixelzoom commented 5 months ago

@arouinfar please review, close if OK.

arouinfar commented 5 months ago

Thanks @pixelzoom, the changes look good on main. During revie, I noticed a possible dynamic layout bug and reported it in #258.

Closing.