phetsims / gas-properties

"Gas Properties" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 6 forks source link

Revisit the order of panels #259

Closed pixelzoom closed 5 months ago

pixelzoom commented 5 months ago

Related to https://github.com/phetsims/gas-properties/issues/213, @arouinfar and @Nancy-Salpepi would like to revisit the order of the panels at the right edge of the Ideal, Explore, and Energy screens.

pixelzoom commented 5 months ago

Design meeting 6/13/2024 @arouinfar @Nancy-Salpepi @kathy-phet @ariel-phet @KatieWoe

Decisions for first 3 screens:

pixelzoom commented 5 months ago

@arouinfar @Nancy-Salpepi Ready for review. Note. that removing vertical space when accordion boxes are collapsed will be done in https://github.com/phetsims/gas-properties/issues/264.

Nancy-Salpepi commented 5 months ago

Looks great! Thanks @pixelzoom!

arouinfar commented 5 months ago

The new panel order is feeling good to me. Once focus order is settled in #213, let's ask the rest of the team to review.

pixelzoom commented 5 months ago

https://github.com/phetsims/gas-properties/issues/213 is done. Let's get sign-off on the new layout of panels from @Nancy-Salpepi and @kathy-phet.

Nancy-Salpepi commented 5 months ago

Commented last week. Looks good to me!

kathy-phet commented 5 months ago

Panel order looks good to me too. Feel free to close.

pixelzoom commented 5 months ago

We have consensus, so closing.