search

phetsims / gas-properties

"Gas Properties" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 6 forks source link

What color should the resize handle be? #274

Closed Nancy-Salpepi closed 4 days ago

Nancy-Salpepi commented 2 weeks ago

While testing https://github.com/phetsims/qa/issues/1100, I noticed that the resize handle is brassy on the Ideal Screen and gray (same color as lid handle) on the Explore Screen. I see that @arouinfar mentioned changing the color here, but it was never changed. @arouinfar which color did you want the resize handle to be?

Screenshot 2024-06-21 at 1 35 32 PM Screenshot 2024-06-21 at 1 35 20 PM

pixelzoom commented 6 days ago

See below for the design document specification for handle color. I've never been a fan of this. It's too subtle and even potentially confusing. For anyone who does notice the color difference, the color alone is incapable of communicating what's intended here. My vote would be to use the same handle color in all cases.

screenshot_3385
pixelzoom commented 6 days ago

@arouinfar @Nancy-Salpepi and I decided in standup meeting to use the same handle color (grey) for both screens.

pixelzoom commented 4 days ago

@Nancy-Salpepi please review, close if OK. Be sure to check in Color Editor, where the handle colors are resizeHandleColor and lidHandleColor.

Nancy-Salpepi commented 4 days ago

Handle colors are now the same. Thanks!