search

phetsims / gas-properties

"Gas Properties" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 6 forks source link

Stepping forward in upstream sim while paused doesn't change state of downstream sim #280

Closed Nancy-Salpepi closed 2 months ago

Nancy-Salpepi commented 3 months ago

Test device MacBook Air M1 chip and iPad

Operating System 14.5 and 17.5.1

Browser Safari 17.5

Problem description For https://github.com/phetsims/qa/issues/1100, while trying to replicate https://github.com/phetsims/gas-properties/issues/282 I came across another issue that occurs while paused. In the state wrapper, on any screen, if you use the step forward button in the upstream sim the particles do not update in the downstream sim.

Steps to reproduce

  1. In the state wrapper, on any screen press Pause in the upstream sim
  2. Add some particles
  3. Continuously press the Step Forward button--the particles do not update in the downstream sim.

Visuals

Screenshot 2024-06-25 at 8 45 48 PM Screenshot 2024-06-25 at 8 51 56 PM
pixelzoom commented 3 months ago

Reproduced in main.

Note that #276 and #280 are both bad State Wrapper behavior when the sim is paused, and both related to the position of particles.

This is probably related to incorrect or missing use(s) of isSettingPhetioStateProperty, in relation to isPlayingProperty.

pixelzoom commented 2 months ago

This was fixed by https://github.com/phetsims/gas-properties/commit/98b2d2d886e7f407188e5f70af451543a3ed1cec over in https://github.com/phetsims/gas-properties/issues/276. (I love it when that happens.)

@Nancy-Salpepi please verify, close if OK.

Nancy-Salpepi commented 2 months ago

yup! This guy is fixed too!