Closed Nancy-Salpepi closed 3 months ago
@arouinfar Please consider waiting until you have a complete list of changes related to https://github.com/phetsims/qa/issues/1107, and making those changes as one commit to gas-properties main. Since we're in RC testing, that commit will need to be patched into new branches of phet-io-sim-specific for gas-properties, gases-intro, and diffusion. I'll be happy to handle the patching, but dealing with 1 commit would make my life easier.
These need to be featured:
gasProperties.diffusionScreen.view.panels.settingsPanel.numberOfParticlesControls.visibleProperty
gasProperties.diffusionScreen.view.panels.settingsPanel.massControls.visibleProperty
gasProperties.diffusionScreen.view.panels.settingsPanel.radiusControls.visibleProperty
gasProperties.diffusionScreen.view.panels.settingsPanel.initialTemperatureControls.visibleProperty
@pixelzoom edit: Tracking in https://github.com/phetsims/gas-properties/issues/286.
For Gases Intro (https://github.com/phetsims/qa/issues/1108):
For Diffusion (https://github.com/phetsims/qa/issues/1109) the examples.md looks good. The visibleProperty for the diffusion variables has been fixed in #286
Looks like QA has completed https://github.com/phetsims/qa/issues/1107, so @arouinfar can proceed with making changes. Assign to me when you're done, and I'll cherry-pick.
Thanks @Nancy-Salpepi! I've made the 3 changes identified in this issue along with some minor formatting tweaks. The Diffusion sim did not require any changes.
@pixelzoom the above commits are ready to cherry-pick.
Release branches are patched. Ready for verification in 1.1.0-rc.2, for gas-properties and gases-intro. There were no examples.md changes for diffusion.
Please verify for https://github.com/phetsims/qa/issues/1123 and https://github.com/phetsims/qa/issues/1124. (There were no changes for the Diffusion sim.)
If everything looks OK, please close this issue.
Changes look good in rc.2 for Gas Properties and Gases Intro. Closing.
In the example doc for Gases Intro, there were some properties with incorrect capitalization. This does not impact searching. From Slack:
Amy Rouinfar
Since it doesn't affect searching, I'm inclined to leave it alone, assuming there isn't anything else to fix. Regardless, reopen the issue because it should get fixed on main, even if we decide not to patch
Oh man! Sorry I missed that @arouinfar!
@arouinfar and I discussed. I fixed in the above commit, will cherry-pick next. We don't feel this is worthy of QA's time, and the QA Pipeline overfloweth. If no other problems are found, I'll publish 1.1.0-rc.3 and have @arouinfar verify, then publish production.
@arouinfar please verify in https://phet-dev.colorado.edu/html/gases-intro/1.1.0-rc.3/phet-io/. Close if OK.
Looks good in rc.3, closing.
gasProperties.idealScreen.view.viewProperties.particleTypeProperty
togasProperties.energyScreen.view.viewProperties.particleTypeProperty
I will continue to add to this issue if I find anything else.