search

phetsims / gas-properties

"Gas Properties" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 6 forks source link

Average Temperature changes when the Number of Particles is decreased #287

Closed Nancy-Salpepi closed 1 month ago

Nancy-Salpepi commented 1 month ago

Test device MacBook Air M1 chip

Operating System 14.5

Browser Safari 17.5

Problem description For https://github.com/phetsims/qa/issues/1107, on the Diffusion screen, if I add particles and then remove some, the Tavg changes. This also happens in published.

Steps to reproduce

  1. Go to the Diffusion Screen
  2. Open the Data panel
  3. Add 50 blue particles
  4. Decrease the number of particles to 40

Visuals

https://github.com/user-attachments/assets/13215ac7-7b5a-4b4b-86cb-c50bab5152de

pixelzoom commented 1 month ago

Reproduced in main.

pixelzoom commented 1 month ago

Fixed in https://github.com/phetsims/gas-properties/commit/a3b0abe7bf067a4ffb8a5a61d21139b481ed62b1, the other commits are to patch release branches.

@Nancy-Salpepi please review in main. Leave open for verification in 1.1.0-rc.2.

Nancy-Salpepi commented 1 month ago

Looks great in main!

pixelzoom commented 1 month ago

Please verify for https://github.com/phetsims/qa/issues/1123 and https://github.com/phetsims/qa/issues/1125. (This issue is irrelevant for the Gases Intro sim.)

To verify, follow "Steps to reproduce" in https://github.com/phetsims/gas-properties/issues/287#issue-2414455259.

If everything looks OK, please close this issue.

KatieWoe commented 1 month ago

Looks fixed in rc.2