phetsims / gas-properties

"Gas Properties" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 6 forks source link

Remove "Adjust in smaller steps" from Diffusion #290

Closed Nancy-Salpepi closed 3 months ago

Nancy-Salpepi commented 3 months ago

Test device MacBook Air M1 chip

Operating System 14.5

Browser Safari 17.5

Problem description For https://github.com/phetsims/qa/issues/1123 and https://github.com/phetsims/qa/issues/1125, since the step size is specific for the particle properties (ex. # particles, radius, mass, and temperature) there are no smaller step sizes for this screen/sim.

Perhaps we should remove the "Adjust in smaller steps" from the keyboard dialog.

Visuals

Screenshot 2024-07-30 at 11 36 56 AM
pixelzoom commented 3 months ago

It looks like there is an includeSmallerStepsRow option available for this, so no common-code changes would be needed. But it would require a patch and another RC spot-check for all 3 sims. Unless other problems are found in 1.1.0-rc.2, my opinion is that it's not worth the cost, because keyboard-help dialogs have bigger general problems. @arouinfar your thoughts?

pixelzoom commented 3 months ago

@arouinfar and I discussed. I fixed in the above commit, will cherry-pick next. We don't feel this is worthy of QA's time, and the QA Pipeline overfloweth. If no other problems are found, I'll publish 1.1.0-rc.3 and have @arouinfar verify, then publish production.

pixelzoom commented 3 months ago

@arouinfar please verify in:

Close if OK.

arouinfar commented 3 months ago

Looks good in rc.3 for both sims, thanks @pixelzoom. Closing.

image