search

phetsims / gene-expression-essentials

An educational simulation about how genes work to create proteins.
GNU General Public License v3.0
4 stars 6 forks source link

RNA polymerase molecules are never wandering on the DNA #118

Closed jbphet closed 6 years ago

jbphet commented 6 years ago

While working on a code cleanup issue (see #52), I stumbled across a bug. The code in DnaMolecule.eliminateInvalidAttachmentSites is not correctly eliminating the biomolecule under test from the list of those that it compares for overlap. The result of this is that all potential attachment sites are eliminated and the biomolecules that attach to the DNA never wander back and forth on the DNA strand, which they are supposed to do.

jbphet commented 6 years ago

This is now fixed on master. Assigning to @ariel-phet to discuss whether this warrants a maintenance release. Since this adds something that is instructive, my opinion is that a maintenance release should be done.

jbphet commented 6 years ago

I discussed this with @ariel-phet, and he agreed that I should do a maintenance release. He had the idea of potentially using this as a test case for the chipper 2.0 integration that is due to take place next Tuesday, 1/16/2018. I'm marking the issue for developer meeting so we can decide if that would be valuable.

jbphet commented 6 years ago

This fix was just deployed in release 1.0.1. Closing.