search

phetsims / gene-expression-essentials

An educational simulation about how genes work to create proteins.
GNU General Public License v3.0
4 stars 6 forks source link

'grunt published-README' was not run in 1.0 branch #122

Closed pixelzoom closed 6 years ago

pixelzoom commented 6 years ago

The 1.0 branches of this sim still indicate that the sim is unpublished.

The master checklist for sims says:

  • [ ] README.md updated using grunt published-README (in master and release branch)
pixelzoom commented 6 years ago

This appears to be a problem with grunt production. It runs grunt published-README in master, but not in the release branch.

jbphet commented 6 years ago

Done. I'd never thought about doing this, since I figured the README file was mostly viewed on the master branch, but it makes sense that this should be done on the first published branch as well. @pixelzoom - it there a general issue in chipper or perennial to make the grunt task automatically update the README.md for the first RC branch too? I looked around but didn't see such an issue.

pixelzoom commented 6 years ago

General issue is https://github.com/phetsims/chipper/issues/698.