search

phetsims / gene-expression-essentials

An educational simulation about how genes work to create proteins.
GNU General Public License v3.0
4 stars 6 forks source link

Should offsetFromDestinationProperty be renamed? #128

Closed samreid closed 4 years ago

samreid commented 4 years ago

From https://github.com/phetsims/scenery-phet/issues/531

This code is in MoveDirectlyToDestinationMotionStrategy.js

    // Fixed offset from the destination position property used when computing the actual target destination. This is
    // useful in cases where something needs to move such that some point that is not its center is positioned at the
    // destination.
    this.offsetFromDestinationProperty = destinationOffset; //@private

offsetFromDestinationProperty doesn't seem like an axon Property, should it be renamed?

jbphet commented 4 years ago

Fixed, thanks for pointing that out. It probably had been a Property in the past and got revised, and I missed the name change at the time. Closing.