search

phetsims / gene-expression-essentials

An educational simulation about how genes work to create proteins.
GNU General Public License v3.0
4 stars 6 forks source link

Borders on florescent cells are grainy in iOS 13 #129

Closed KatieWoe closed 4 years ago

KatieWoe commented 4 years ago

For https://github.com/phetsims/QA/issues/433, low priority. The white outline of the cells on the last screen seem blurrier on iOS 13 than on iOS 12. Easier to see when there are many cells, but can still be seen with just one. Image from iOS

jonathanolson commented 4 years ago

I can't reproduce in the simulator, but I CAN reproduce on my iPhone.

jbphet commented 4 years ago

I can reproduce using the as yet unnamed iOS 13 device, iOS version 13.1.3. I can duplicate it not happening on Hopper, iOS version 12.4.1.

jbphet commented 4 years ago

I think I've figured this out. The cell shape is intentionally designed to be imperfect, i.e. to have some irregularities in order to appear more realistic. On the iOS 13 device, which may have higher screen resolution, the joins between the different line segments are visible. I add a lineJoin attribute to the Scenery node that represents the cell body and set the value to round, and the problem went away.

@KatieWoe - please have someone test the master version of this on various platforms and make sure that my change didn't have any unintentional consequences. If it all looks good, please assign this back to me, and I'll move the change to the release branch and do a quick-and-easy maintenance release once the other big maintenance releases that are currently in progress have finished.

KatieWoe commented 4 years ago

Things are looking ok after a quick check on master

jbphet commented 4 years ago

I added the fix for this issue to the 1.0 release branch, built and tested on Chrome, Firefox, and iOS 13, and it all looks good. Since this is a low-risk change, I'm planning to piggyback on the maintenance release that is currently in progress and have this change go out with that release. That one is apparently close, so once it goes out, I'll verify this issue.

jonathanolson commented 4 years ago

This should be out.

jbphet commented 4 years ago

I just tested on the iOS 13 device, and the problem is fixed in the published version of the sim. Closing.