search

phetsims / gene-expression-essentials

An educational simulation about how genes work to create proteins.
GNU General Public License v3.0
4 stars 6 forks source link

adjust touchArea options for HSlider thumb #13

Closed pixelzoom closed 7 years ago

pixelzoom commented 8 years ago

In https://github.com/phetsims/sun/issues/254, the touchArea defaults for HSlider thumb were changed so that they default to pixels, not a percentage of the thumb size. Sims that use HSlider's thumbSize option will therefore need to also specify thumbTouchAreaXDilation and thumbTouchAreaYDilation.

pixelzoom commented 8 years ago

Btw... There's some dead code in HorizontalSliderWithLabelsAtEnds that you might want to clean up.

jbphet commented 8 years ago

Assigning to @aadish, since he is taking over on this sim.

aadish commented 7 years ago

touch area looks good, closing