search

phetsims / gene-expression-essentials

An educational simulation about how genes work to create proteins.
GNU General Public License v3.0
4 stars 6 forks source link

problems with ControlPanelNode #134

Closed pixelzoom closed 3 years ago

pixelzoom commented 3 years ago

Same problem as in https://github.com/phetsims/area-builder/issues/114 ...

ControlPanelNode is defining this.expandedProperty, which is also defined in the superclass.

ControlPanelNode is also poorly named. It extends AccordionBox, so should have a name with "AccordionBox" suffix.

pixelzoom commented 3 years ago

In the above commit, I converted to ES6, deleted this.expandedProperty, and confirmed that Reset All is working.

I did not rename ControlPanelNode.

jbphet commented 3 years ago

I reviewed the commit and it looked good, and renamed ControlPanelNode to ParameterControlAccordionBox. Closing.