search

phetsims / gene-expression-essentials

An educational simulation about how genes work to create proteins.
GNU General Public License v3.0
4 stars 6 forks source link

Automated testing error (build) 2/16/17 #37

Closed jessegreenberg closed 7 years ago

jessegreenberg commented 7 years ago 
gene-expression-essentials
Uncaught TypeError: Cannot read property 'show' of undefined
TypeError: Cannot read property 'show' of undefined
    at listener (http://localhost:8080/gene-expression-essentials/build/gene-expression-essentials_en.html?ea&audioVolume=0&testDuration=10000&testConcurrentBuilds=4&fuzzMouse&postMessageOnLoad&postMessageOnError:956:30595)
    at http://localhost:8080/gene-expression-essentials/build/gene-expression-essentials_en.html?ea&audioVolume=0&testDuration=10000&testConcurrentBuilds=4&fuzzMouse&postMessageOnLoad&postMessageOnError:950:28565
    at Array.forEach (native)
    at e.fire (http://localhost:8080/gene-expression-essentials/build/gene-expression-essentials_en.html?ea&audioVolume=0&testDuration=10000&testConcurrentBuilds=4&fuzzMouse&postMessageOnLoad&postMessageOnError:950:28545)
    at Array. (http://localhost:8080/gene-expression-essentials/build/gene-expression-essentials_en.html?ea&audioVolume=0&testDuration=10000&testConcurrentBuilds=4&fuzzMouse&postMessageOnLoad&postMessageOnError:950:27906)
    at emit2 (http://localhost:8080/gene-expression-essentials/build/gene-expression-essentials_en.html?ea&audioVolume=0&testDuration=10000&testConcurrentBuilds=4&fuzzMouse&postMessageOnLoad&postMessageOnError:931:30086)
    at e._notifyObservers (http://localhost:8080/gene-expression-essentials/build/gene-expression-essentials_en.html?ea&audioVolume=0&testDuration=10000&testConcurrentBuilds=4&fuzzMouse&postMessageOnLoad&postMessageOnError:932:1471)
    at e._setAndNotifyObservers (http://localhost:8080/gene-expression-essentials/build/gene-expression-essentials_en.html?ea&audioVolume=0&testDuration=10000&testConcurrentBuilds=4&fuzzMouse&postMessageOnLoad&postMessageOnError:932:1334)
    at e.set (http://localhost:8080/gene-expression-essentials/build/gene-expression-essentials_en.html?ea&audioVolume=0&testDuration=10000&testConcurrentBuilds=4&fuzzMouse&postMessageOnLoad&postMessageOnError:932:1075)
    at Object.up (http://localhost:8080/gene-expression-essentials/build/gene-expression-essentials_en.html?ea&audioVolume=0&testDuration=10000&testConcurrentBuilds=4&fuzzMouse&postMessageOnLoad&postMessageOnError:952:2236)

Found during a fuzz test of the built version.

phet-steele commented 7 years ago

@jessegreenberg @aadish I believe this was fixed with https://github.com/phetsims/gene-expression-essentials/commit/8419ab8b39477cb40fc704f68a77ad92d90ecce2. If this error was anything like phetsims/molecules-and-light/issues/137, it would be much more prevalent in bayes testing. It has not been reported, nor can I reproduce it like I can phetsims/molecules-and-light/issues/137.

To further elaborate, this was probably caused by this line of code, which was removed in the linked commit:

if( !this.fluorescentCellsPictureDialog ) {
     this.createFluorescentCellsPictureDialog();
}

Closing.