search

phetsims / gene-expression-essentials

An educational simulation about how genes work to create proteins.
GNU General Public License v3.0
4 stars 6 forks source link

Shouldn't AttachedToBasePair be AttachedToBasePairState or AttachedAndWanderingState? #52

Closed jbphet closed 6 years ago

jbphet commented 7 years ago

The name of AttachedToBasePair seems inconsistent with the names of the other states, which all end with "State", e.g. AttachedAndTranscribingState.

jbphet commented 7 years ago

I just checked the Java code, and AttachedToBasePair was indeed the name in the Java sim. I'm going to defer this one for now. We may change it when we are ready to publish, but for now it is probably best to leave the names the same in case we need to compare the HTML5 version to the Java version.

jbphet commented 6 years ago

Unassigning for now, but I would like to do this just before creating the first RC branch. I want to hold off until then in case I need to go back an reference the original Java code in the immediate future.

jbphet commented 6 years ago

Dang - I missed doing this before the RC. I may try to get it in before the actual publication, or just do it on master.

jbphet commented 6 years ago

This has been done on master. I hadn't planned to move it to the release branch, but it will likely end up there since I found and fixed a bug that will probably require a maintenance release, and all of the changes were committed at once. At any rate, this has now been addressed, closing.