phetsims / gene-expression-essentials

An educational simulation about how genes work to create proteins.
GNU General Public License v3.0
4 stars 6 forks source link

protein capture area bounds looks odd when initially created #68

Closed jbphet closed 7 years ago

jbphet commented 7 years ago

The type ManualGeneExpressionModel has the following declaration within it:

    // Rectangle that describes the "protein capture area".  When a protein is dropped by the user over this area, it
    // is considered to be captured.
    this.proteinCaptureArea = new Bounds2( 0, 0, 1, 1 ); // @private

This seems like an arbitrary initial value, but the comment doesn't state that. If that's what it is, it should probably instead be initially set to Bounds2.NOTHING and the comment should mention when it gets set.

aadish commented 7 years ago

fixed, closing