search

phetsims / gene-expression-essentials

An educational simulation about how genes work to create proteins.
GNU General Public License v3.0
4 stars 6 forks source link

FlashController should be a separate type #73

Closed jbphet closed 6 years ago

jbphet commented 7 years ago

The type FlashController is defined as an inner type in the file FlashingShapeNode.js. It should be pulled out into a separate file to facilitate reuse and readability. Also, the parameters onTime, offTime, numFlashes, flashOnAtStart and flashOnAtEnd should be made into options using PhET's usual options pattern.

aadish commented 7 years ago

FlashController has been ported out, leaving this issue open for QA-Testing

jbphet commented 6 years ago

I've reviewed and tested the changes, and did some minor cleanup. This looks good, closing.