search

phetsims / gene-expression-essentials

An educational simulation about how genes work to create proteins.
GNU General Public License v3.0
4 stars 6 forks source link

Make BasePairs break when doing Transcription of DNA Molecule #79

Closed aadish closed 6 years ago

aadish commented 7 years ago

@phet-steele has suggested that it would be nice that break pairs could break as DNA molecule changes when transcribing the DNA molecule. This issue is to track this request

aadish commented 7 years ago

b9d4b4eedde04c55c9469eaa2522048f9c808411

Implemented this behavior in above commit

@phet-steele can you pull the latest and see if it is desired beahvior

jbphet commented 6 years ago

Bumping to high priority. @phet-steele - please review behavior and comment on whether this behavior is an improvement that should be retained, and if there are any additional changes that you'd recommend. Once done, please assign back to me and I'll take it from there. I'll at least need to evaluate the performance and make sure that this doesn't cause any significant degradation over the previous behavior.

phet-steele commented 6 years ago

This is great, and a much belated thank you to @aadish!

@jbphet and I discussed a bit ago on an improvement for this. During what we will call the "red twist" (where the red DNA strand originates on top of the turn before being split), the reconnection of base pairs happens well before the strands have settled back into their starting positions. This causes unfortunate layering to occur: gee04

@jbphet proposed to shorten the base pair rectangles during this moment, then re-expand them as the strands move upwards to give the illusion of the red strand passing in front of the base pairs as it "twists".

jbphet commented 6 years ago

I fixed this, but blew the commit comment, so the commit is https://github.com/phetsims/gene-expression-essentials/commit/cf9af3a000fcd4181b792ca98e7305715bb5640c.

jbphet commented 6 years ago

@phet-steele - please take a look at the version now on master and close if you think the changes cover it.

phet-steele commented 6 years ago

@jbphet this is great! There are just small things that are a little weird that I think we could all come to live with. I feel fine to close, thanks.