search

phetsims / gene-expression-essentials

An educational simulation about how genes work to create proteins.
GNU General Public License v3.0
4 stars 6 forks source link

improve type and visibility annotations #84

Open jbphet opened 6 years ago

jbphet commented 6 years ago

Type and visibility annotations mostly exist, but aren't very consistent with how they are currently done. They should be improved.

jbphet commented 6 years ago

I've done some work on this, focusing on the most important types, but it could still use some improvement, mostly due to the fact that the port was done by multiple individuals, so the approach is not consistent throughout the code. @ariel-phet and I discussed and we decided to leave this issue unassigned and open so that if and when this sim comes up for instrumentation we could review, decide if further effort is needed, and spend some more time on it then if so.