search

phetsims / gene-expression-essentials

An educational simulation about how genes work to create proteins.
GNU General Public License v3.0
4 stars 6 forks source link

ribosomes and mRNA destroyers jump to mRNA instead of animating #91

Closed jbphet closed 6 years ago

jbphet commented 6 years ago

On master and on all previously published dev versions, the ribosomes and mRNA destroyers jump to the end of the mRNA strand instead of animating there. In the Java version, they animate.

phet-steele commented 6 years ago

@jbphet see #24 for why this occurs, although it differs from what I requested in https://github.com/phetsims/gene-expression-essentials/issues/24#issuecomment-293010804.

ariel-phet commented 6 years ago

@jbphet @phet-steele I cannot say the "jumping" bothers me when user initiated, since it seems to occur in a fairly tight radius to the "ghost cue" highlight.

It is a bit odd however, when it happens "in the wild" as it does not look physically correct.

We should ideally make sure the bug in #24 does not occur, but jumping also does not occur if it is not user initiated (if animating all the time is easiest, I am fine with that solution).

jbphet commented 6 years ago

I've implemented a solution to this where the destroyers and ribosomes move quickly and directly to attach to the mRNA if the mRNA is in the process of being transcribed, and move in the "meandering" motion toward the mRNA if the mRNA is floating freely. This looks much better to my eye and doesn't suffer from the problem described in #24.

jbphet commented 6 years ago

Unassigning, will have this verified in next dev release.

phet-steele commented 6 years ago

Looks great.