search

phetsims / gene-expression-essentials

An educational simulation about how genes work to create proteins.
GNU General Public License v3.0
4 stars 6 forks source link

continuous testing error #93

Closed jessegreenberg closed 6 years ago

jessegreenberg commented 6 years ago 
ene-expression-essentials : fuzz : require.js : load
Uncaught Error: Assertion failed: Cannot add the same listener twice
Error: Assertion failed: Cannot add the same listener twice
    at window.assertions.assertFunction (https://bayes.colorado.edu/continuous-testing/snapshot-1507227560393/assert/js/assert.js:22:13)
    at Emitter.addListener (https://bayes.colorado.edu/continuous-testing/snapshot-1507227560393/axon/js/Emitter.js?bust=1507229267918:97:17)
    at Property.link (https://bayes.colorado.edu/continuous-testing/snapshot-1507227560393/axon/js/Property.js?bust=1507229267918:246:29)
    at new PlacementHintNode (https://bayes.colorado.edu/continuous-testing/snapshot-1507227560393/gene-expression-essentials/js/common/view/PlacementHintNode.js?bust=1507229267918:78:33)
    at https://bayes.colorado.edu/continuous-testing/snapshot-1507227560393/gene-expression-essentials/js/manual-gene-expression/view/ManualGeneExpressionScreenView.js?bust=1507229267918:96:38
    at Array.forEach (<anonymous>)
    at https://bayes.colorado.edu/continuous-testing/snapshot-1507227560393/gene-expression-essentials/js/manual-gene-expression/view/ManualGeneExpressionScreenView.js?bust=1507229267918:95:32
    at Array.forEach (<anonymous>)
    at new ManualGeneExpressionScreenView (https://bayes.colorado.edu/continuous-testing/snapshot-1507227560393/gene-expression-essentials/js/manual-gene-expression/view/ManualGeneExpressionScreenView.js?bust=1507229267918:94:39)
    at ManualGeneExpressionScreen.createView (https://bayes.colorado.edu/continuous-testing/snapshot-1507227560393/gene-expression-essentials/js/manual-gene-expression/ManualGeneExpressionScreen.js?bust=1507229267918:41:34)
Approximately 10/5/2017, 12:19:20 PM

Very likely caused by merging listeners branch in https://github.com/phetsims/axon/issues/140. Assigning to @jbphet because he is the responsible dev.

jbphet commented 6 years ago

Should be fixed - it was just a duplicated line of code, so this is exactly the sort of thing we're hoping to catch with these changes. I'll check the automated test in a couple of hours and, if all looks good, I'll close.

jbphet commented 6 years ago

This sim is no longer failing the continuous tests, closing.