Some string clean up - Githubissues

phet-steele commented 6 years ago

@jbphet I've done 3 things with the following commits. Please review and approve of the changes.

ecb9beb941a2d8a1f60a47e3b92f92a9937281a1 Removed quotes from "Collection Complete!"
6978d9978a17088a46f31261c34b135dae6773af Added a space between "Gene" and it's index for each GeneNode on the first screen, eg. was "Gene1" now "Gene 1". I changed this in DnaMoleculeNode.js rather than in the strings file so that the space isn't accidentally lost during translation.

4ce8ab2e03169868fb06f4b9d3a3982fc67fc49a Capitalized "slow" and "fast" for the Protein Degradation slider since we use title case for slider labels.

For phetsims/QA/issues/58.

phet-steele commented 6 years ago

@jbphet , the more I think about it, we may not need https://github.com/phetsims/gene-expression-essentials/commit/6978d9978a17088a46f31261c34b135dae6773af. gene (in the strings file) should just be a pattern.

jbphet commented 6 years ago

+1

jbphet commented 6 years ago

The first and third changes look good, and I went ahead and made the gene label into a pattern.

jbphet commented 6 years ago

This is fixed and reviewed, closing.

phetsims / gene-expression-essentials