search

phetsims / geometric-optics

Geometric Optics is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 5 forks source link

Examples document lists element that doesn't exist. #466

Closed KatieWoe closed 1 year ago

KatieWoe commented 1 year ago

geometricOptics.general.view.navigationBar.preferencesButton.preferencesDialogCapsule.preferencesDialog.preferencesPanels.simulationPreferencesPanel.simPreferences.focalLengthModelTypeControl.visibleProperty is listed in the examples but does not seem to exist. I suspect it should read geometricOptics.general.view.navigationBar.preferencesButton.preferencesDialogCapsule.archetype.preferencesPanels.simulationPreferencesPanel.simPreferences.focalLengthModelTypeControl.visibleProperty instead, with the archetype section missing in the examples document. For https://github.com/phetsims/qa/issues/938

Nancy-Salpepi commented 1 year ago

@KatieWoe I have encountered this a few times. I keep forgetting that the preferences dialog needs to be open first. Then it works. My eyes alway skip over that sentence, even though it is there!

Screenshot 2023-05-10 at 5 31 53 PM
arouinfar commented 1 year ago

Thanks @Nancy-Salpepi! You are correct, the issue here is that the Preferences dialog wasn't first opened. Since the examples doc includes this reminder, there isn't really anything to do here, closing.