search

phetsims / geometric-optics

Geometric Optics is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 5 forks source link

Delete `dispose` for keyboard help #483

Closed pixelzoom closed 1 year ago

pixelzoom commented 1 year ago

From https://github.com/phetsims/phet-io/issues/1810#issuecomment-1574191794 ...

dispose is no longer needed for keyboard help, and related code in this sim should be deleted.

On hold until 1.3 is published, so that we don't complicate cherry-picks.

pixelzoom commented 1 year ago

Done in the above commit. Tested with unbuild, Studio, and State Wrapper.

Closing.