Missing dependencies for DerivedProperties

[pixelzoom]

Discovered in https://github.com/phetsims/axon/issues/441 ...

• [x] In Lens, missing dependency on this.indirectFocalLengthModel.indexOfRefractionProperty.range, which is actually a Property:

    this.opacityProperty = new DerivedProperty( [ this.indexOfRefractionProperty ],
      indexOfRefraction => {

        // Use the indirect model's IOR range in all cases, because the direct model's IOR is fixed.
        phet.skipit = true;
        const range = this.indirectFocalLengthModel.indexOfRefractionProperty.range;
        phet.skipit = false;
        return Utils.linear( range.min, range.max, 0.2, 1, indexOfRefraction );
      } );

• [x] In Guide, missing dependency on optic.opticSurfaceTypeProperty:

    this.transmittedAngleProperty = new DerivedProperty(
      [ optic.focalLengthProperty, optic.diameterProperty, this.incidentAngleProperty ],
...
        const deflectedAngle = ( optic.opticSurfaceTypeProperty.value === 'convex' ) ?

• [x] In LightSpot, there is a very deeply-nested dependency on Lens opticSurfaceTypeProperty and Optic shapesProperty, via getPositionAndDiameter => getTopPoint => getExtremePoint => getActiveBoundsTranslated:

    const positionAndDiameterProperty = new DerivedProperty(
      [ optic.positionProperty, optic.diameterProperty, projectionScreen.positionProperty, lightObjectPositionProperty, opticalImagePositionProperty ],
      ( opticPosition, opticDiameter, projectionScreenPosition, lightObjectPosition, opticalImagePosition ) =>
        getPositionAndDiameter( optic, projectionScreenPosition, lightObjectPosition, opticalImagePosition )
    );

• [x] Also in LightSpot, missing dependency on optic.diameterProperty.range, which is actually a Property:

    this.intensityProperty = new DerivedProperty( [ this.diameterProperty, optic.diameterProperty ],
...
          const opticDiameterRange = optic.diameterProperty.range;

• [x] In ArrowObjectNode, missing dependencies on optic.positionProperty and arrowObject.positionProperty:

    const dragBoundsProperty = new DerivedProperty(
      [ sceneBoundsProperty, objectDragModeProperty ],
...
        const maxX = optic.positionProperty.value.x - GOConstants.MIN_DISTANCE_FROM_OBJECT_TO_OPTIC;
...
          minY = Math.max( sceneBounds.minY, optic.positionProperty.value.x - ArrowObject.MAX_MAGNITUDE );
          maxY = Math.min( sceneBounds.maxY, optic.positionProperty.value.x + ArrowObject.MAX_MAGNITUDE );
...
          minY = arrowObject.positionProperty.value.y;
          maxY = arrowObject.positionProperty.value.y;

• [x] In HTMLImageElementObjectNode, missing dependencies on htmlImageElementObject.positionProperty and opticPositionProperty:

const dragBoundsProperty = new DerivedProperty(
      [ htmlImageElementObject.boundsProperty, sceneBoundsProperty, objectDragModeProperty ],
...
        const htmlImageElementObjectPosition = htmlImageElementObject.positionProperty.value;
...
        const maxX = Math.floor( opticPositionProperty.value.x - GOConstants.MIN_DISTANCE_FROM_OBJECT_TO_OPTIC );

• [x] In GOLabelNode, missing dependency on zoomTransformProperty:

    const opticalAxisLabelPositionProperty = new DerivedProperty(
      [ optic.positionProperty, modelVisibleBoundsProperty ],
      ( opticPosition, modelVisibleBounds ) => {
        const modelXOffset = zoomTransformProperty.value.viewToModelDeltaX( 10 );
        return new Vector2( modelVisibleBounds.x + modelXOffset, opticPosition.y );
      } );

[pixelzoom]

In https://github.com/phetsims/geometric-optics/commit/84b714a9c46de2439f9df38acc747f7931404e21, @samreid added accessNonDependencies: true to temporarily silence these problems.

[pixelzoom]

One case remaining, positionAndDiameterProperty in LightSpot.

[pixelzoom]

All occurrences of accessNonDependencies have been addressed. Closing.