search

phetsims / graphing-quadratics

"Graphing Quadratics" is an educational simulation in HTML5, by PhET Interactive Simulations.
MIT License
1 stars 4 forks source link

Slight overlap between Point on Parabola Coordinates and Accordion Box #159

Closed Nancy-Salpepi closed 3 years ago

Nancy-Salpepi commented 3 years ago

https://github.com/phetsims/qa/issues/692

In the Focus and Directrix screen, I noticed a slight overlap between the Point on Parabola values and the accordion box. After speaking with @amanda-phet, we were wondering if there was an area to make space so that this overlap doesn't happen?

Screen Shot 2021-08-18 at 3 18 02 PM Screen Shot 2021-08-18 at 2 52 40 PM
pixelzoom commented 3 years ago

The screenshot below shows the full context.

Coordinates overlap the accordion box for some (not all) coordinate values. And they do not overlap (obscure) anything in the accordion box, so there is no usability impact here.

If you don't want this overlap to occur, then you have 2 options:

(1) Add more horizontal space between the graph and the accordion box. This will impact all screens. (2) Shift the graph to the left, which will make problems like https://github.com/phetsims/graphing-quadratics/issues/91 and https://github.com/phetsims/graphing-quadratics/issues/161 worse. This will impact all screens.

I don't think the UI will benefit in any way by either of these options, so my recommendation is "do nothing".

screenshot_1199
pixelzoom commented 3 years ago

Here's the closest that I could come to making the coordinates overlap something in the accordion box:

screenshot_1200
pixelzoom commented 3 years ago

Another option would be to limit coordinates to 1 decimal place. But there's probably a good reason why they are 2 decimal places.

pixelzoom commented 3 years ago

Note that there is precedent for allowing Point On Parabola to overlap, even with other interactive UI components. See https://github.com/phetsims/graphing-quadratics/issues/126.

amanda-phet commented 3 years ago

@pixelzoom thanks for finding those more dramatic cases. I thought if it was just a few pixels of overlap we might consider finding the room, since it's aesthetically annoying, but the max amount of possible overlap is too great to be able to find the space to avoid it. So I think we should leave this as-is.