search

phetsims / graphing-quadratics

"Graphing Quadratics" is an educational simulation in HTML5, by PhET Interactive Simulations.
MIT License
1 stars 4 forks source link

HTML comment in PhET-iO guide #168

Closed liammulh closed 3 years ago

liammulh commented 3 years ago

I was skimming through the guide and I noticed there's an HTML comment that somehow got displayed. Should be an easy fix. Wasn't sure if this was sim-specific or general, so move the issue if necessary. For https://github.com/phetsims/qa/issues/692.

See the comment circled in the screenshot below. comment

pixelzoom commented 3 years ago

This is for @amanda-phet, she's the lead designer for graphing-quadratics. @amanda-phet please also check whether this needs to be fixed in a general template.

amanda-phet commented 3 years ago

@liam-mulhall I'm confused because this isn't the GQ guide. I am not familiar with the source you got a screenshot from, but I'm not seeing the error (or the lack of content) in the guide here: https://github.com/phetsims/phet-io-client-guides/blob/master/graphing-quadratics/phet-io-guide.md

Can you help me understand the guide you're looking at?

amanda-phet commented 3 years ago

OK I found it here: https://phet-dev.colorado.edu/html/graphing-quadratics/1.2.0-rc.1/phet-io/doc/guides/phet-io-guide.html and I'm really confused by this. That table is in fact commented out, so I can delete it, but it's strange to me that it's being displayed that way.

For now, I will delete that chunk of the guide, but I'd like to investigate this some more with @arouinfar when she returns from vacation.

amanda-phet commented 3 years ago

Over to @pixelzoom to cherry-pick this commit.

pixelzoom commented 3 years ago

@amanda-phet said:

... but I'd like to investigate this some more with @arouinfar when she returns from vacation.

@amanda-phet and @arouinfar can follow up in https://github.com/phetsims/phet-io-client-guides/issues/13.

pixelzoom commented 3 years ago

Patched into 1.2 release in the above commit.

Ready for testing in the next RC. To verify, run the Wrapper Index, click on the "PhET-iO Guide" link, and verify that the stuff (circled in red) in the screenshot in https://github.com/phetsims/graphing-quadratics/issues/168#issue-977502799 is not visibile.

KatieWoe commented 3 years ago

This seems fixed in rc.2