search

phetsims / graphing-quadratics

"Graphing Quadratics" is an educational simulation in HTML5, by PhET Interactive Simulations.
MIT License
1 stars 4 forks source link

Revise screenshots. #174

Closed pixelzoom closed 1 year ago

pixelzoom commented 3 years ago

The look of the point tool was changed in https://github.com/phetsims/graphing-quadratics/issues/167, so screenshots will need to be revised. This does not need to be addressed proactively, as other visual changes might be made before this sim is republished.

pixelzoom commented 2 years ago

@amanda-phet Could you please revise screenshots by 7/19?

This sim is scheduled for publication as part of https://github.com/orgs/phetsims/projects/44, and it's likely to happen while I'm on vacation.

You can attach screenshots to this issue, or check them into GitHub directly -- your choice. See https://github.com/phetsims/graphing-quadratics/tree/master/assets for the list of screenshots.

amanda-phet commented 2 years ago

All screenshots are in the assets folder. Tagging as ready for review by QA.

pixelzoom commented 1 year ago

I reviewed this again for https://github.com/phetsims/graphing-quadratics/issues/176, to make sure there have been no significant changes in the past year that require new screenshots. The size of icons in the navigation bar have change a little bit, but not enough to be noticable in screenshots. And there are no new features or changes that would require new screenshots. So we're still good to go here.

For dev testing, QA should verify that the screenshots in https://github.com/phetsims/graphing-quadratics/tree/master/assets match the 1.3 dev version. Please close this issue after verifying.

KatieWoe commented 1 year ago

Does the addition of the preferences menu icon require new screenshots?

pixelzoom commented 1 year ago

Since @arouinfar will be the one who has to make the screenshots, I'm going to defer to her. But my opinion is that changes to the navigaiton batr (like the Preferences button) are not significant enough (or visibile enough) to be a require new screenshots.

pixelzoom commented 1 year ago

I should also note that the Preferences button only appears in the "all" version of the sim. It's not present in locale-specific versions because there are no sim-specific Preferences. So this is a good reason NOT to show the Preferences button in screenshots.

arouinfar commented 1 year ago

But my opinion is that changes to the navigaiton batr (like the Preferences button) are not significant enough (or visibile enough) to be a require new screenshots.

I agree. I don't think we need to take new screenshots in this situation.

I should also note that the Preferences button only appears in the "all" version of the sim. It's not present in locale-specific versions because there are no sim-specific Preferences. So this is a good reason NOT to show the Preferences button in screenshots.

We now serve the "all" version of the simulation on the sim page, so I think it's fine for the Preferences button to show up in screenshots. I just don't think we need to retake screenshots for that sole reason, closing.