search

phetsims / graphing-quadratics

"Graphing Quadratics" is an educational simulation in HTML5, by PhET Interactive Simulations.
MIT License
1 stars 4 forks source link

Uninstrument `equationAccordionBox.titleNode` #190

Closed arouinfar closed 1 year ago

arouinfar commented 1 year ago

For #180

In #187 Text and RichText were uninstrumented, including things like titleText. However, it looks like @pixelzoom may have missed one:

exploreScreen.view.equationAccordionBox.titleNode

image

There isn't any reason to instrument this titleNode. Its only child is a read-only visibleProperty whose value never changes.

pixelzoom commented 1 year ago

equationAccordionBox.titleNode was uninstrumented throughout in the above commits above. @arouinfar please review, close if OK.

pixelzoom commented 1 year ago

This change also required migration rules (see above commit), which git-hooks did not check for me. Luckily I remembered to check manually using the Migration wrapper. Had I deferred until publishing, this would have been a lot more work to figure out what/where went wrong.

arouinfar commented 1 year ago

Thanks @pixelzoom, looks good. Glad you tested things out in the Migration wrapper!