Equation AccordionBox doesn't properly resize when `interactiveEquationNode` is partially hidden

phetsims / graphing-quadratics

"Graphing Quadratics" is an educational simulation in HTML5, by PhET Interactive Simulations.

MIT License

1 stars 4 forks source link

Equation AccordionBox doesn't properly resize when `interactiveEquationNode` is partially hidden #192

Closed arouinfar closed 1 year ago

arouinfar commented 1 year ago

For #180

When all three sliders in the Equation AccordionBox are hidden, the layout does not dynamically change to eliminate the blank space. equationAccordionBox.interactiveEquationNode.*Slider.visibleProperty

Hiding the interactiveEquationNode resizes things as expected, however.

arouinfar commented 1 year ago

Actually, this appears to be a more general issue with the interactiveEquationNode which contains the sliders and an equationNode.

Hiding interatctivieEquationNode.equationNode also results in a gap in the layout.

pixelzoom commented 1 year ago

Reproduced in master.

pixelzoom commented 1 year ago

Fixed in the above commit. @arouinfar please review, close if OK.

arouinfar commented 1 year ago

Thanks @pixelzoom. Looks good in master, closing.