search

phetsims / graphing-quadratics

"Graphing Quadratics" is an educational simulation in HTML5, by PhET Interactive Simulations.
MIT License
1 stars 4 forks source link

Missing separator at top of equationAccordionBox content. #193

Closed pixelzoom closed 1 year ago

pixelzoom commented 1 year ago

While working on https://github.com/phetsims/graphing-quadratics/issues/192, I noticed that we lost the separator at the top of every equationAccordionBox. The separator is still in the code, but because there's nothing about it in "content" of the accordion box, scenery's layout manager automatically hides it. This is because scenery takes a very literal view of "separator" -- there must be a visible Node on both sides of the separator, or it will be hidden.

Here is equationAccordionBox in the 4 screens of the published version (1.2.13):

screenshot_2626 screenshot_2627 screenshot_2628 screenshot_2635

Compare to master. Note the absence of the separator between the accordion box's title and content.

screenshot_2630 screenshot_2632 screenshot_2633 screenshot_2634
pixelzoom commented 1 year ago

Fixed in the above commits, and the restored separator automatically disappears if not needed. @arouinfar please reivew, compare to published version 1.2.13 at https://phet.colorado.edu/sims/html/graphing-quadratics/latest/graphing-quadratics_all.html. And beware of https://github.com/phetsims/sun/issues/848 - if the entire content of an AccordionBox is hidden, the entire AccordionBox becomes invisible.

arouinfar commented 1 year ago

Good catch! Looks good in master, closing.