Eliminate dependency on graphing-lines.Graph

phetsims / graphing-quadratics

"Graphing Quadratics" is an educational simulation in HTML5, by PhET Interactive Simulations.

MIT License

1 stars 4 forks source link

Eliminate dependency on graphing-lines.Graph #201

Closed pixelzoom closed 1 year ago

pixelzoom commented 1 year ago

graphing-quadratics uses these files from graphing-lines:

Graph.ts
GraphNode.ts
Manipulator.ts
PointToolBodyNode.ts

Of these, Graph.ts will be problematic when graphing-lines is eventually instrumented for PhET-iO. Specifically, Graph has field lines: ObservableArray<Line> which is irrelevant for (and ignored by) graphing-quadratics.

pixelzoom commented 1 year ago

Nevermind. GQGraphNode uses GraphNode via composition, and it expects a Graph. Closing, and will deal with this in the future.